On 11/19/20 12:08 PM, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
>> On Thu, Nov 19, 2020 at 11:15:33AM -0500, Joe Conway wrote:
>>> On 11/19/20 11:06 AM, Tom Lane wrote:
>>>> Let's just rip it out and be done. If anyone is ever
>>>> motivated to make it work per spec, they can resurrect
>>>> whatever seems useful from the git history.
>
>>> +1
>
>> +1
>
> Here's a proposed patch for that. I was amused to discover that we have
> a couple of regression test cases making use of IS OF.
I didn't check but those might be my fault ;-)
> However, I think using pg_typeof() is actually better for those tests anyway, since
> printing the regtype result is clearer, and easier to debug if the test
> ever goes wrong.
Looks good to me.
Joe
--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development