On 20.02.23 13:33, Nazir Bilal Yavuz wrote:
> I added SSL and UUID patches. UUID patch has two different fixes:
>
> 1 - v1-0002-meson-Refactor-UUID-option.patch: Adding 'auto' choice to
> 'uuid' combo option.
>
> 2 - v1-0002-meson-Refactor-UUID-option-with-uuid_library.patch: Making
> 'uuid' feature option and adding new 'uuid_library' combo option with
> ['auto', 'bsd', 'e2fs', 'ossp'] choices. If 'uuid_library' is set other
> than 'auto' and it can't be found, build throws an error.
>
> What do you think?
I like the second approach, with a 'uuid' feature option. As you wrote
earlier, adding an 'auto' choice to a combo option doesn't work fully
like a real feature option.
But what does uuid_library=auto do? Which one does it pick? This is
not a behavior we currently have, is it?
I would rename the ssl_type variable to ssl_library, so that if we ever
expose that as an option, it would be consistent with uuid_library.