RE: Re: Log a sample of transactions

Поиск
Список
Период
Сортировка
От Kuroda, Hayato
Тема RE: Re: Log a sample of transactions
Дата
Msg-id 1F66B161998C704BABF8989B8A2AC0A31CDD2C@G01JPEXMBYT05
обсуждение исходный текст
Ответ на Re: Re: Log a sample of transactions  (David Steele <david@pgmasters.net>)
Ответы Re: Log a sample of transactions
Список pgsql-hackers
Dear David,

I have a will and already read the patch, but I thought it's not my turn.
Sorry.


Adrien,

>  I did not find any test for log_min_duration that could help me. LCOV indicate
> there is no tests on this part (look check_log_duration()):
> https://coverage.postgresql.org/src/backend/tcop/postgres.c.gcov.html

I understand the unnecessarily of some test case. It's OK.

Finally, how do you think about the deviation of randomness?
If this parameter is set very low, nobody may be output because of the deviation.
we can avoid this phenomenon by counting up internal parameter for each transactions and output to log file if the
parameterbecomes  more than 1.
 

After consideration for this case and rebasing, I think this patch is enough.
Do I have to measure the change of throughput?


Best Regards,
Hayato Kuroda
Fujitsu LIMITED



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: setLastTid() and currtid()
Следующее
От: Tatsuro Yamada
Дата:
Сообщение: Re: [HACKERS] CLUSTER command progress monitor