Re: Improve pgindent's formatting named fields in struct literals and varidic functions
| От | Chao Li |
|---|---|
| Тема | Re: Improve pgindent's formatting named fields in struct literals and varidic functions |
| Дата | |
| Msg-id | 1C9E26A3-8C99-4624-8981-7D42E852C274@gmail.com обсуждение |
| Ответ на | Re: Improve pgindent's formatting named fields in struct literals and varidic functions (Andreas Karlsson <andreas@proxel.se>) |
| Список | pgsql-hackers |
> On Mar 31, 2026, at 16:03, Andreas Karlsson <andreas@proxel.se> wrote: > > On 3/31/26 9:16 AM, Jelte Fennema-Nio wrote: >> On Tue, 31 Mar 2026 at 08:30, Andreas Karlsson <andreas@proxel.se> wrote: >>> Rebased it again. >> I agree this looks better. So seems like a reasonable improvement. > > Thanks for taking a look! > > But noticed now that the tests were broken so here is a new version where they pass and where I also added a new test casefor struct literals with named fields. > > Andreas > <v4-0001-Make-pgindent-add-a-space-between-comma-and-perio.patch><v4-0002-Run-pgindent-add-a-space-between-comma-and-period.patch> I applied the patch and played with it a little bit. I didn’t find any problem. The patch idea looks reasonable to me, aftera comma, dot is no longer acting as structure member access, so inserting a white space feels good. I saw a couple of typos in the commit message: varidic -> variadic treaing -> treating Overall, looks good to me. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
В списке pgsql-hackers по дате отправления: