Re: Add two missing tests in 035_standby_logical_decoding.pl

Hi,

On 4/26/23 12:27 PM, Alvaro Herrera wrote:
>> diff --git a/src/test/perl/PostgreSQL/Test/Cluster.pm b/src/test/perl/PostgreSQL/Test/Cluster.pm
>> index 6f7f4e5de4..819667d42a 100644
>> --- a/src/test/perl/PostgreSQL/Test/Cluster.pm
>> +++ b/src/test/perl/PostgreSQL/Test/Cluster.pm
>> @@ -2644,7 +2644,16 @@ sub wait_for_catchup
>>       }
>>       if (!defined($target_lsn))
>>       {
>> -        $target_lsn = $self->lsn('write');
>> +        my $isrecovery = $self->safe_psql('postgres', "SELECT pg_is_in_recovery()");
>> +        chomp($isrecovery);
>> +        if ($isrecovery eq 't')
>> +        {
>> +            $target_lsn = $self->lsn('replay');
>> +        }
>> +        else
>> +        {
>> +            $target_lsn = $self->lsn('write');
>> +        }
> 
> Please modify the function's documentation to account for this code change.
> 

Good point, thanks! Done in V6 attached.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com