>> I do not believe that this could ever have passed regression. Do we have
>> the whole patch to back out, or do we need to just "fix what we have now"?
>>
>> Also, perhaps we need to be more selective about checkins?
>
>Not sure. Marc and I reviewed it, and it looked very good. In fact, I
>would like to see more of such patches, of course, without the destroydb
>problem, but many patches have little quirks the author could not have
>anticipated.
>
>> {
>> JunkFilter *j = (JunkFilter *) ExecInitJunkFilter(targetList);
>> estate->es_junkFilter = j;
>> >>>> tupType = j->jf_cleanTupType; /* Added by daveh@insightdist.com 5/20/98 */
>> }
>> else
>> estate->es_junkFilter = NULL;
>>
>> Here is my debug transcript for "drop database regression"
>
>Here is the original patch. I got it with the command:
I have just removed the patch using patch -R and confirmed that "drop
table", and "delete from" works again. regression tests also look
good, except char/varchar/strings.
Now I can start to create patches for snapshot...
--
Tatsuo Ishii
t-ishii@sra.co.jp