Re: [pgsql-patches] Patch to avoid gprofprofilingoverwrites

Bruce Momjian <bruce@momjian.us> writes:

> +     CFLAGS="$CFLAGS -DPROFILE_PID_DIR -pg ${PROFILE_CFLAGS}"

Kindly use AC_DEFINE instead of random -D in CFLAGS (which is the wrong
place for -D anyway).  Also, what exactly is the point here of
PROFILE_CFLAGS?  I thought it was supposed to allow substituting
something else for -pg, but you've managed to defeat that.

> +         snprintf(gprofDirName, MAXPGPATH, "./gprof/%d", getpid());

getpid is not int everywhere; use a cast.  Also, the "./" bits are
silly, and if you ask me so is the MAXPGPATH-sized buffer for a string
that can't exceed 20 or so bytes.

            regards, tom lane