Re: pgcrypto: Makefile check

Neil Conway <neilc@samurai.com> writes:
> Perhaps I wasn't clear: the *present* behavior of pgcrypto is to
> "compile successfully but ... be unusable" if an invalid random source
> is defined. This is prone to error. That patch changes this behavior to
> refuse to compile if an invalid random source has been defined.

Ah, got it.

> I don't think this is a problem (an invalid random source is effectively
> a misconfiguration and could only be the result of user error). But if
> you like I can change the patch so that we error out when attempting to
> compile random.c

Please do; I dislike makefiles that won't "make clean" ...

            regards, tom lane