Re: Removing savepointLevel from TransactionState
| От | Tom Lane |
|---|---|
| Тема | Re: Removing savepointLevel from TransactionState |
| Дата | |
| Msg-id | 19847.1317273112@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Removing savepointLevel from TransactionState (Gurjeet Singh <singh.gurjeet@gmail.com>) |
| Ответы |
Re: Removing savepointLevel from TransactionState
Re: Removing savepointLevel from TransactionState |
| Список | pgsql-hackers |
Gurjeet Singh <singh.gurjeet@gmail.com> writes:
> I noticed that the savepointLevel member of TransactionStateData struct is
> initialized to 0 from TopTransactionStateData, and never incremented or
> decremented afterwards.
> Since this is a file-local struct I think we can simply get rid of all
> usages of this without any risk.
ISTM you have detected a bug, not just dead code that should be removed.
Surely those tests that throw error on savepointLevel change were
meant to do something important?
regards, tom lane
В списке pgsql-hackers по дате отправления: