[HACKERS] fd,c just Assert()s that lseek() succeeds

Поиск
Список
Период
Сортировка
От Tom Lane
Тема [HACKERS] fd,c just Assert()s that lseek() succeeds
Дата
Msg-id 19699.1487567845@sss.pgh.pa.us
обсуждение исходный текст
Ответы Re: [HACKERS] fd,c just Assert()s that lseek() succeeds  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
I noticed while researching bug #14555 that fd.c contains two separate
cases like
vfdP->seekPos = lseek(vfdP->fd, (off_t) 0, SEEK_CUR);Assert(vfdP->seekPos != (off_t) -1);

This seems, um, unwise.  It might somehow fail to fail in production
builds, because elsewhere it's assumed that -1 means FileUnknownPos,
but it seems like reporting the error would be a better plan.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Rafia Sabih
Дата:
Сообщение: Re: [HACKERS] Passing query string to workers
Следующее
От: Ashutosh Bapat
Дата:
Сообщение: Re: [HACKERS] Parallel Append implementation