Re: [BUGS] BUG #1118: Misleading Commit message

Bruce Momjian <pgman@candle.pha.pa.us> writes:
>>> I am not excited about changing the command tag.
>> 
>> I was not either to start with, but the more I think about it, the more
>> I think it would be a good idea.

> What tag would we use?  ABORT?

No, ROLLBACK, which is what you get when you give the "expected"
command.

regression=# begin;
BEGIN
regression=# select 1/0;
ERROR:  division by zero
regression=# abort;        -- or rollback;
ROLLBACK

regression=# begin;
BEGIN
regression=# select 1/0;
ERROR:  division by zero
regression=# commit;
COMMIT

I think the above is fairly misleading; it would be better to say
ROLLBACK to indicate that we had in fact canceled the transaction.
        regards, tom lane