"Simon Riggs" <simon@2ndquadrant.com> writes:
> The first function reads a single block from a file, returning the
> complete page as a bytea of length BLCKSZ.
> CREATE OR REPLACE FUNCTION bufpage_get_raw_page(text, int4)
> RETURNS bytea ...
Directly from the file? What if the version in buffers is completely
different? OTOH, if you try to pull from shared buffers then you won't
be able to deal with corrupted pages, so I think you are claiming that
the function can serve purposes that it can't really fulfill
simultaneously.
As for putting it in core, we already had that discussion w.r.t. the
adminpack functions, and you have not provided any argument adequate
to override the concerns expressed about those.
regards, tom lane