Re: Confused about gram.y referencs in Makefile?
| От | Tom Lane |
|---|---|
| Тема | Re: Confused about gram.y referencs in Makefile? |
| Дата | |
| Msg-id | 18971.1695655794@sss.pgh.pa.us обсуждение |
| Ответ на | Re: Confused about gram.y referencs in Makefile? (Daniel Gustafsson <daniel@yesql.se>) |
| Список | pgsql-hackers |
Daniel Gustafsson <daniel@yesql.se> writes:
> On 25 Sep 2023, at 05:34, Japin Li <japinli@hotmail.com> wrote:
>> How about "See gram.h target's comment in src/backend/parser/Makefile"
>> or just "See src/backend/parser/Makefile"?
> The latter seems more stable, if the Makefile is ever restructured it's almost
> guaranteed that this comment will be missed with the location info becoming
> stale.
I did it like this:
# Note that while each script call produces two output files, to be
-# parallel-make safe we need to split this into two rules. (See for
-# example gram.y for more explanation.)
+# parallel-make safe we need to split this into two rules. (See notes
+# in src/backend/parser/Makefile about rules with multiple outputs.)
#
There are a whole lot of other cross-references to that same comment,
and they all look like
# See notes in src/backend/parser/Makefile about the following two rules
I considered modifying all of those as well, but decided it wasn't
really worth the trouble. The Makefiles' days are numbered I think.
regards, tom lane
В списке pgsql-hackers по дате отправления: