Re: [PATCH] readlink missing nul-termination in pg_rewind

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] readlink missing nul-termination in pg_rewind
Дата
Msg-id 18909.1432831616@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] readlink missing nul-termination in pg_rewind  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Ответы Re: [PATCH] readlink missing nul-termination in pg_rewind  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
Abhijit Menon-Sen <ams@2ndQuadrant.com> writes:
> P.S. Also in passing, I note that pg_rewind will follow links under any
> directory anywhere named pg_tblspc (which probably doesn't matter), and
> does not follow pg_xlog if it's a symlink (which probably does). If you
> want, I can submit a trivial patch for the latter.

As far as that goes, I think it does look at the whole parentpath, which
means it would not be fooled by sub-subdirectories named pg_tblspc.
A bigger problem is that whoever coded this forgot that parentpath could
be null, which I blame on the lack of an API specification for the
function.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Devrim GÜNDÜZ
Дата:
Сообщение: Re: rhel6 rpm file locations
Следующее
От: Tom Lane
Дата:
Сообщение: Re: fsync-pgdata-on-recovery tries to write to more files than previously