Florian Pflug <fgp@phlo.org> writes:
> In the process of re-verifying my serializable lock consistency patch, I ran
> the fk_concurrency testsuite against *unpatched* HEAD for comparison.
> My build of HEAD had asserts enabled, and I promptly triggered
> Assert(!(tp.t_data->t_infomask & HEAP_XMAX_INVALID))
> in heap_delete().
> The seems wrong, if result was set to HeapTupleUpdated because the tuple was invisible
> to the crosscheck snapshot, its xmax may very well be invalid.
This patch seems certainly wrong. Please provide an actual test case
rather than just asserting we should change this.
regards, tom lane