Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [HACKERS] [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.
Дата
Msg-id 1820.1507918762@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [HACKERS] [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.  (Andres Freund <andres@anarazel.de>)
Ответы Re: [HACKERS] [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.
Список pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> A easiest way to do this would be to put something like
> CPPFLAGS="$CPPFLAGS -Dpg_restrict" into the existing
> if test "$GCC" != yes ; then
> block in a/src/template/linux. But that'd probably result in "macro
> redefined" warnings or somesuch.

You mean src/template/aix, no?  Agreed, that seems like a reasonable
place to control it.  But I'm pretty sure the above would flat out
not work, the #define in pg_config.h would override it.

> So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set
> at the same place, that's then tested before running the relevant
> configure check?

+1.  I think you don't actually have to skip the configure check,
and there might be some value in letting it carry on normally
(so that "restrict" is set properly).  We'd just want it to affect
what pg_restrict gets defined as.  Something like

if test "$ac_cv_c_restrict" = "no" -o "x$FORCE_DISABLE_RESTRICT" = "xyes"; then pg_restrict=""
else pg_restrict="$ac_cv_c_restrict"
fi
        regards, tom lane


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

В списке pgsql-committers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.
Следующее
От: Andres Freund
Дата:
Сообщение: Re: [HACKERS] [COMMITTERS] pgsql: Improve performance ofSendRowDescriptionMessage.