RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG

Поиск
Список
Период
Сортировка
Искать
От
Higuchi, Daisuke
Тема
RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG
Дата
Msg-id
1803D792815FC24D871C00D17AE95905D39101@g01jpexmbkw24
Ответ на
Список
Дерево обсуждения
[Bug Fix]ECPG: cancellation of significant digits on ECPG "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>
RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>
Re: [Bug Fix]ECPG: cancellation of significant digits on ECPG Dmitry Dolgov <9erthalion6@gmail.com>
RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>
Re: [Bug Fix]ECPG: cancellation of significant digits on ECPG Tom Lane <tgl@sss.pgh.pa.us>
RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>
Re: [Bug Fix]ECPG: cancellation of significant digits on ECPG Tom Lane <tgl@sss.pgh.pa.us>
Re: [Bug Fix]ECPG: cancellation of significant digits on ECPG Tom Lane <tgl@sss.pgh.pa.us>
Re: [Bug Fix]ECPG: cancellation of significant digits on ECPG Dmitry Dolgov <9erthalion6@gmail.com>
RE: [Bug Fix]ECPG: cancellation of significant digits on ECPG "Higuchi, Daisuke" <higuchi.daisuke@jp.fujitsu.com>
From: Tom Lane [mailto:tgl@sss.pgh.pa.us] 
>I took a quick look at this. 
Thank you for review. 

>So I think that we ought to unconditionally make the sqlda value's digit 
>buffer look just like the one we're copying, even when ndigits = 0, 
>which just requires removing the tests on ndigits.

I agree with you. Seeing this thread[1], 'if (ndigits = 0)' was introduced only to avoid memcpy() crash. I do not know this solution was best or not, but no crash occurs in the current version. So, I also think 'if (ndigits = 0)' should be removed.

>In short, the attached.
Thank you for updating. This patch looks good to me. 

[1]
https://www.postgresql.org/message-id/4EC825F3.5080504%40cybertec.at

Regards,
Daisuke Higuchi



В списке pgsql-hackers по дате отправления
От: Thomas Munro
Дата:
Сообщение: Re: Copy data to DSA area
От: Michael Paquier
Дата:
FAQ