Re: Ordering of header file inclusion

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Ordering of header file inclusion
Дата
Msg-id 17924.1574433427@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Ordering of header file inclusion  (vignesh C <vignesh21@gmail.com>)
Ответы Re: Ordering of header file inclusion  (Amit Kapila <amit.kapila16@gmail.com>)
Список pgsql-hackers
vignesh C <vignesh21@gmail.com> writes:
> After the inclusion they have define and further include based on #if
> defined. In few cases I had seen the include happens at the end of the
> file like in regcomp.c as there may be impact. I felt it is better not
> to change these files. Let me know your thoughts on the same.

I think the point of this patch series is just to make cosmetic
adjustments in places where people have randomly failed to maintain
alphabetic order of a consecutive group of #include's.  Messing with
examples like the above is way out of scope, if you ask me --- it
entails more analysis, and more risk of breakage, than a purely
cosmetic goal is worth.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Attempt to consolidate reading of XLOG page
Следующее
От: Dmitry Dolgov
Дата:
Сообщение: Re: SimpleLruTruncate() mutual exclusion