Re: Doc: CREATE_REPLICATION_SLOT command requires the plugin name

Amit Kapila <amit.kapila16@gmail.com> wrote:

> On Tue, Feb 1, 2022 at 3:44 PM Antonin Houska <ah@cybertec.at> wrote:
> >
> > I got a syntax error when using the command according to the existing
> > documentation. The output_plugin parameter needs to be passed too.
> >
> 
> Why do we need it for physical slots?

Sure we don't, the missing curly brackets seem to be the problem. I used the
other form of the command for reference, which therefore might need a minor
fix too.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 24e93f9b28..49fae6c669 100644
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -1942,7 +1942,7 @@ The commands accepted in replication mode are:
   </varlistentry>
 
   <varlistentry id="protocol-replication-create-slot" xreflabel="CREATE_REPLICATION_SLOT">
-   <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [
<literal>TEMPORARY</literal>] { <literal>PHYSICAL</literal> | <literal>LOGICAL</literal> } [ ( <replaceable
class="parameter">option</replaceable>[, ...] ) ]
 
+   <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [
<literal>TEMPORARY</literal>] { <literal>PHYSICAL</literal> | { <literal>LOGICAL</literal> <replaceable
class="parameter">output_plugin</replaceable>} } [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ]
 
      <indexterm><primary>CREATE_REPLICATION_SLOT</primary></indexterm>
     </term>
     <listitem>
@@ -2085,7 +2085,8 @@ The commands accepted in replication mode are:
   </varlistentry>
 
   <varlistentry>
-    <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [
<literal>TEMPORARY</literal>] { <literal>PHYSICAL</literal> [ <literal>RESERVE_WAL</literal> ] |
<literal>LOGICAL</literal><replaceable class="parameter">output_plugin</replaceable> [
<literal>EXPORT_SNAPSHOT</literal>| <literal>NOEXPORT_SNAPSHOT</literal> | <literal>USE_SNAPSHOT</literal> |
<literal>TWO_PHASE</literal>] }
 
+    <term><literal>CREATE_REPLICATION_SLOT</literal> <replaceable class="parameter">slot_name</replaceable> [
<literal>TEMPORARY</literal>] { <literal>PHYSICAL</literal> [ <literal>RESERVE_WAL</literal> ] | {
<literal>LOGICAL</literal><replaceable class="parameter">output_plugin</replaceable>
 
+} [ <literal>EXPORT_SNAPSHOT</literal> | <literal>NOEXPORT_SNAPSHOT</literal> | <literal>USE_SNAPSHOT</literal> |
<literal>TWO_PHASE</literal>] }
 
     </term>
     <listitem>
      <para>