Re: txid strtoull fix

"Marko Kreen" <markokr@gmail.com> writes:
> On 10/8/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (Note that your overflow test didn't actually work; AFAIK there
>> really isn't any decent solution other than dividing at each step.)

> Hmm.  It did seem to work here.  Just in case I peeked into
> FreeBSD strtoull() and this patch imitates their method.

Well, it worked for the one specific case you tested, but there are
other cases it would fail to detect overflow for.  (When you're
multiplying by ten, the overflow might not be small.)  The FreeBSD
way looks OK though --- applied.

            regards, tom lane