Re: progress report for ANALYZE

Hi All,

>> *All* phases are repeated in this case, not not just "finalizing
>> analyze", because ANALYZE repeatedly runs for each partition after the
>> parent partitioned table's ANALYZE finishes.  ANALYZE's documentation
>> mentions that analyzing a partitioned table also analyzes all of its
>> partitions, so users should expect to see the progress information for
>> each partition.  So, I don't think we need to clarify that if only in
>> one phase's description.  Maybe we can add a note after the phase
>> description table which mentions this implementation detail about
>> partitioned tables.  Like this:
>>
>>    
>>     
>>      Note that when ANALYZE is run on a partitioned table,
>>      all of its partitions are also recursively analyzed as also mentioned on
>>      .  In that case, ANALYZE
>>      progress is reported first for the parent table, whereby its inheritance
>>      statistics are collected, followed by that for each partition.
>>     
>>    
> 
> 
> Ah.. you are right: All phases are repeated, it shouldn't be fixed
> the only one phase's description.
> 
> 
>> Some more comments on the documentation:
>>
>> +       Number of computed extended stats.  This counter only advances
>> when the phase
>> +       is computing extended stats.
>>
>> Number of computed extended stats -> Number of extended stats computed
> 
> 
> Will fix.
> 
> 
>> +       Number of analyzed child tables.  This counter only advances
>> when the phase
>> +       is computing extended stats.
>>
>> Regarding, "Number of analyzed child table", note that we don't
>> "analyze" child tables in this phase, only scan its blocks to collect
>> samples for parent's ANALYZE.  Also, the 2nd sentence is wrong -- you
>> meant "when the phase is acquiring inherited sample
>> rows.  I suggest to write this as follows:
>>
>> Number of child tables scanned.  This counter only advances when the phase
>> is acquiring inherited sample rows.
> 
> 
> Oops, I will fix it. :)
> 
> 
> 
>> +     OID of the child table currently being scanned.
>> +       It might be different from relid when analyzing tables that
>> have child tables.
>>
>> I suggest:
>>
>> OID of the child table currently being scanned.  This field is only valid when
>> the phase is computing extended stats.
> 
> 
> Will fix.
> 
> 
>> +       The command is currently scanning the
>> current_relid
>> +       to obtain samples.
>>
>> I suggest:
>>
>> The command is currently scanning the the table given by
>> current_relid to obtain sample rows.
> 
> 
> Will fix.
> 
> 
>> +       The command is currently scanning the
>> current_child_table_relid
>> +       to obtain samples.
>>
>> I suggest (based on phase description pg_stat_progress_create_index
>> phase descriptions):
>>
>> The command is currently scanning child tables to obtain sample rows.  Columns
>> child_tables_total,
>> child_tables_done, and
>> current_child_table_relid contain the progress
>> information for this phase.
> 
> 
> Will fix.
> 
> 
>> +    
>> +     computing stats
>>
>> I think the phase name should really be "computing statistics", that
>> is, use the full word.
> 
> 
> Will fix.
> 
> 
>> +     
>> +       The command is computing stats from the samples obtained
>> during the table scan.
>> +     
>> +    
>>
>> So I suggest:
>>
>> The command is computing statistics from the sample rows obtained during
>> the table scan
> 
> 
> Will fix.
> 
> 
>> +     computing extended stats
>> +     
>> +       The command is computing extended stats from the samples
>> obtained in the previous phase.
>> +     
>>
>> I suggest:
>>
>> The command is computing extended statistics from the sample rows obtained
>> during the table scan.
> 
> 
> Will fix.


I fixed the document based on Amit's comments. :)
Please find attached file.


Thanks,
Tatsuro Yamadas