Robert Haas <robertmhaas@gmail.com> writes:
> I'm inclined to commit both of these after a little more testing and
> self-review, but let me know if anyone else wants to review first.
Looking through the first one, I wondered whether we needed to
check for a qual expression on Gather or GatherMerge. It seems like
it would be stupid to put a filter on that node rather than its
children, but I see this in both nodeGather.c and nodeGatherMerge.c:
/* * initialize child expressions */gatherstate->ps.qual = ExecInitQual(node->plan.qual, (PlanState *)
gatherstate);
It doesn't look like the qual is actually used anywhere in either node
type. Am I right in thinking this is dead code?
regards, tom lane