Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Jan-19, Michael Paquier wrote:
>> +use File::Glob ':bsd_glob';
>> +use File::Path qw(remove_tree make_path);
>> +use File::Spec::Functions qw(catdir catfile);
>> Is this compatible with our minimum perl requirements for the TAP
>> tests?

> I *think* :bsd_glob should be available in all the Perl versions we
> support, but I'm not sure that we really need it.  We seem to do just
> fine with regular glob elsewhere.

We had some previous discussion about that, and Andrew seemed to
think that it wouldn't necessarily be a net win:

https://www.postgresql.org/message-id/fde787ee-9c2d-46da-3ece-f7ae64a70b33%402ndQuadrant.com

In any case, I'd say -1 to having just one place use that.

            regards, tom lane