Re: [PATCH] Add features to pg_stat_statements

On 2020-09-19 16:35, legrand legrand wrote:
> +1 !
> 
> An other way is to log evictions, it provides informations about time 
> and
> amount :
> 
> 	for (i = 0; i < nvictims; i++)
> 	{
> 		hash_search(pgssp_hash, &entries[i]->key, HASH_REMOVE, NULL);
> 	}
> 
> 	pfree(entries);
> 
> 	/* trace when evicting entries, if appening too often this can slow 
> queries
> ...
> 	 * increasing pg_stat_sql_plans.max value could help */
> 	 ereport(LOG,
> 		(errmsg("pg_stat_sql_plans evicting %d entries", nvictims),
> 		errhidecontext(true), errhidestmt(true)));
> 
> 
> 
> --
> Sent from: 
> https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html

Thank you for your comments!
In addition to providing a view that is like a summary of history,
logging might be a good choice.

Regards,
Katsuragi Yuta