Re: Clear out the reminants of EXTEND INDEX

Bruce Momjian <pgman@candle.pha.pa.us> writes:
>>> I always rip that stuff out. We do an initdb for every release.  What
>>> could break by renumbering those nodes?
>>
>> Actually, since we don't store node type numbers on disk (just symbolic
>> names), there's probably nothing that could break as long as people do a
>> full recompile when they update.  It's no worse than changing the fields
>> of a widely-used struct, I suppose.  I was just being paranoid.

On third thought, there is some value to preserving the node numbers:
when we see a bug report from the field like

    ERROR:  ExecEvalExpr: unknown expression type 108

we don't have to resort to excavating back versions of nodes.h to figure
out which node type is meant.

            regards, tom lane