The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
Hi
the patch applies fine on current master branch and it works as described. However, I would suggest changing the new
optionname from "--with-childs" to "--with-partitions" for several reasons.
"childs" is grammatically incorrect and in the PG community, the term "partitioned table" is normally used to denote a
parenttable, and the term "partition" is used to denote the child table under the parent table. We should use these
termsto stay consistent with the community.
Also, I would rephrase the documentation as:
Used in conjunction with <option>-t</option>/<option>--table</option> or
<option>-T</option>/<option>--exclude-table</option>options to include or exclude partitions of the specified tables if
any.
thank you
Cary Huang
================
HighGo Software Canada
www.highgo.ca