Re: transformExpr() refactor

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: transformExpr() refactor
Дата
Msg-id 1673.1098973071@sss.pgh.pa.us
обсуждение исходный текст
Ответ на transformExpr() refactor  (Neil Conway <neilc@samurai.com>)
Ответы Re: transformExpr() refactor  (Neil Conway <neilc@samurai.com>)
Список pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> This patch refactors transformExpr(): rather than being a monsterous 900
> line function, it breaks it up into numerous sub-functions that are
> invoked by transformExpr() for individual expression types, in the style
> of transformStmt().

I don't actually find this to be an improvement.  What's the point?
Since all the switch arms are independent, you haven't really done
anything at all to improve the comprehensibility of the code...

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: Updated Turkish translation: postgres
Следующее
От: Andrew Dunstan
Дата:
Сообщение: rmtree cleanup