Re: [PATCH] Allow specification of custom slot for custom nodes

Поиск
Список
Период
Сортировка
От Pavel Borisov
Тема Re: [PATCH] Allow specification of custom slot for custom nodes
Дата
Msg-id 166903761072.1121.2757138082242561269.pgcf@coridan.postgresql.org
обсуждение исходный текст
Ответ на [PATCH] Allow specification of custom slot for custom nodes  (Alexander Korotkov <aekorotkov@gmail.com>)
Ответы Re: [PATCH] Allow specification of custom slot for custom nodes  (Alexander Korotkov <aekorotkov@gmail.com>)
Список pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionality
unlessanyone (e.g. extension) sets its own slotOps in CustomScanState.
 
Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing
extensibility.So I think adding more extensibility regarding different tuple formats is an excellent thing to do.
 

I'm going to mark it as RfC if there are no objections.

Kind regards,
Pavel Borisov, 
Supabase

The new status of this patch is: Ready for Committer

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Drouvot, Bertrand"
Дата:
Сообщение: Re: Split index and table statistics into different types of stats
Следующее
От: Simon Riggs
Дата:
Сообщение: Re: Allow single table VACUUM in transaction block