Re: Two small patches for the isolationtester lexer

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Two small patches for the isolationtester lexer
Дата
Msg-id 16409.1519855174@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Two small patches for the isolationtester lexer  (Daniel Gustafsson <daniel@yesql.se>)
Список pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 22 Feb 2018, at 05:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Another idea is just to teach addlitchar to realloc the buffer bigger
>> when necessary.

> I think this is the best approach for the task, the attached patch changes the
> static allocation to instead realloc when required.  Having an upper limit on
> the allocation seemed like a good idea to me, but perhaps it’s overthinking and
> complicating things for no good reason.

Yeah, it doesn't seem to me that we need any fixed limit on the length,
so I deleted that part of the logic, and pushed it with one or two other
cosmetic adjustments.

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Nikita Glukhov
Дата:
Сообщение: Re: [HACKERS] [PATCH] kNN for SP-GiST
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Two small patches for the isolationtester lexer