Re: quick question about "WIP: grouping sets support"

2008/11/11 Ibrar Ahmed <ibrar.ahmad@gmail.com>:
> Hi,
>
> I am able to apply your patch successfully but I am still getting
> compilation error
>
>
>  ./configure --enable-depend --enable-cassert
> make
>

hello

it's strange :(. Actually I tested it without significant problems - I
had to replace preproc.y because it was actualised without patching
(in attachement).

but after this change I am able compile and install.

please try
cvs -z3 -d :pserver:anoncvs@anoncvs.postgresql.org:/projects/cvsroot co -P pgsql
cd pgsql
configure --enable-depend --enable-cassert
patch -p0 < gsets.diff.gz
make

regards
Pavel Stehule



>
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
> -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
> -fwrapv -I. -I../../../src/include -D_GNU_SOURCE   -c -o scansup.o
> scansup.c -MMD -MP -MF .deps/scansup.Po
> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
> -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
> -fwrapv -I. -I../../../src/include -D_GNU_SOURCE   -c -o parse_gsets.o
> parse_gsets.c -MMD -MP -MF .deps/parse_gsets.Po
> parse_gsets.c:846: error: conflicting types for 'transform_ungroup_cols_context'
> parse_gsets.c:48: error: previous declaration of
> 'transform_ungroup_cols_context' was here
> parse_gsets.c:850: error: conflicting types for 'set_multiplication'
> parse_gsets.c:548: error: previous definition of 'set_multiplication' was here
> parse_gsets.c:861: error: redefinition of 'expandGSOperators'
> parse_gsets.c:63: error: previous definition of 'expandGSOperators' was here
> parse_gsets.c:948: error: redefinition of 'adjustFields'
> parse_gsets.c:173: error: previous definition of 'adjustFields' was here
> parse_gsets.c:1000: error: redefinition of 'expandGSOperator'
> parse_gsets.c:225: error: previous definition of 'expandGSOperator' was here
> parse_gsets.c:1181: error: redefinition of 'add_unique_gsets'
> parse_gsets.c:406: error: previous definition of 'add_unique_gsets' was here
> parse_gsets.c:1236: error: redefinition of 'multiple'
> parse_gsets.c:461: error: previous definition of 'multiple' was here
> parse_gsets.c:1388: error: conflicting types for
> 'transform_ungroup_cols_mutator'
> parse_gsets.c:624: error: previous definition of
> 'transform_ungroup_cols_mutator' was here
> parse_gsets.c:1449: error: redefinition of 'transformGroupingSetsSpec'
> parse_gsets.c:689: error: previous definition of
> 'transformGroupingSetsSpec' was here
> parse_gsets.c:1607: error: conflicting types for
> 'transform_ungroup_cols_context'
> parse_gsets.c:846: error: previous declaration of
> 'transform_ungroup_cols_context' was here
> parse_gsets.c:1622: error: redefinition of 'expandGSOperators'
> parse_gsets.c:63: error: previous definition of 'expandGSOperators' was here
> parse_gsets.c:1709: error: redefinition of 'adjustFields'
> parse_gsets.c:948: error: previous definition of 'adjustFields' was here
> parse_gsets.c:1761: error: redefinition of 'expandGSOperator'
> parse_gsets.c:1000: error: previous definition of 'expandGSOperator' was here
> parse_gsets.c:1942: error: redefinition of 'add_unique_gsets'
> parse_gsets.c:1181: error: previous definition of 'add_unique_gsets' was here
> parse_gsets.c:1997: error: redefinition of 'multiple'
> parse_gsets.c:1236: error: previous definition of 'multiple' was here
> parse_gsets.c:2084: error: redefinition of 'set_multiplication'
> parse_gsets.c:1323: error: previous definition of 'set_multiplication' was here
> parse_gsets.c:2149: error: conflicting types for
> 'transform_ungroup_cols_mutator'
> parse_gsets.c:1388: error: previous definition of
> 'transform_ungroup_cols_mutator' was here
> parse_gsets.c:2210: error: redefinition of 'transformGroupingSetsSpec'
> parse_gsets.c:689: error: previous definition of
> 'transformGroupingSetsSpec' was here
> make[3]: *** [parse_gsets.o] Error 1
> make[3]: Leaving directory
> `/home/ibrar/edb-work/PostgreSQL/postgresql/src/backend/parser'
> make[2]: *** [parser-recursive] Error 2
> make[2]: Leaving directory
> `/home/ibrar/edb-work/PostgreSQL/postgresql/src/backend'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/home/ibrar/edb-work/PostgreSQL/postgresql/src'
> make: *** [all] Error 2
>
>
>
>
>
> On Tue, Nov 11, 2008 at 9:52 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>> Hello
>>
>> I synced grouping sets with current CVS HEAD. Please, try:
>> http://www.pgsql.cz/patches/gsets.diff.gz
>>
>> Thank you
>> Pavel Stehule
>>
>> 2008/11/10 Ibrar Ahmed <ibrar.ahmad@gmail.com>:
>>> Hi ,
>>>
>>> While I am looking at your patch I am getting compilation error.
>>>
>>> BTW I have downloaded your patch from this link.
>>>
>>> http://archives.postgresql.org/message-id/162867790810170316l4eeecb0bq321dd771f8f4e661@mail.gmail.com
>>>
>>>
>>>
>>>
>>> gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
>>> -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
>>> -fwrapv -I. -I../../../src/include -D_GNU_SOURCE   -c -o parse_gsets.o
>>> parse_gsets.c -MMD -MP -MF .deps/parse_gsets.Po
>>> parse_gsets.c:809: error: conflicting types for 'transform_ungroup_cols_context'
>>> parse_gsets.c:48: error: previous declaration of
>>> 'transform_ungroup_cols_context' was here
>>> parse_gsets.c:824: error: redefinition of 'expandGSOperators'
>>> parse_gsets.c:63: error: previous definition of 'expandGSOperators' was here
>>> parse_gsets.c:911: error: redefinition of 'adjustFields'
>>> parse_gsets.c:150: error: previous definition of 'adjustFields' was here
>>> parse_gsets.c:963: error: redefinition of 'expandGSOperator'
>>> parse_gsets.c:202: error: previous definition of 'expandGSOperator' was here
>>> parse_gsets.c:1144: error: redefinition of 'add_unique_gsets'
>>> parse_gsets.c:383: error: previous definition of 'add_unique_gsets' was here
>>> parse_gsets.c:1199: error: redefinition of 'multiple'
>>> parse_gsets.c:438: error: previous definition of 'multiple' was here
>>> parse_gsets.c:1286: error: redefinition of 'set_multiplication'
>>> parse_gsets.c:525: error: previous definition of 'set_multiplication' was here
>>> parse_gsets.c:1351: error: conflicting types for
>>> 'transform_ungroup_cols_mutator'
>>> parse_gsets.c:590: error: previous definition of
>>> 'transform_ungroup_cols_mutator' was here
>>> parse_gsets.c:1412: error: redefinition of 'transformGroupingSetsSpec'
>>> parse_gsets.c:651: error: previous definition of
>>> 'transformGroupingSetsSpec' was here
>>> make[3]: *** [parse_gsets.o] Error 1
>>> make[3]: Leaving directory
>>> `/home/ibrar/edb-work/PostgreSQL/postgresql/src/backend/parser'
>>> make[2]: *** [parser-recursive] Error 2
>>> make[2]: Leaving directory
>>> `/home/ibrar/edb-work/PostgreSQL/postgresql/src/backend'
>>> make[1]: *** [install] Error 2
>>> make[1]: Leaving directory `/home/ibrar/edb-work/PostgreSQL/postgresql/src'
>>> make: *** [install] Error 2
>>>
>>> --
>>>   Ibrar Ahmed
>>>   EnterpriseDB   http://www.enterprisedb.com
>>>
>>
>
>
>
> --
>   Ibrar Ahmed
>   EnterpriseDB   http://www.enterprisedb.com
>