Re: BUG #15541: Use after release in PQprint

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: BUG #15541: Use after release in PQprint
Дата
Msg-id 16265.1544205750@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: BUG #15541: Use after release in PQprint  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: BUG #15541: Use after release in PQprint  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Список pgsql-bugs
I wrote:
> Wow, that is ancient.  It looks like commit edb519b14 of 27-Jul-1996
> added the pipe close stanza in the wrong place, and nobody's noticed
> it since.  That's probably not so surprising given the multiple
> conditions required to trigger it plus the fact that this whole
> function is, if not completely dead code, at least not used anywhere
> in the PG distribution.  Still, we oughta fix it.

Actually, looking closer at just what those conditions are: the
giant bit of spaghetti code at lines 177-188 will never enable the
pager if po->html3 is on.  Probably that was because of laziness
about counting lines correctly in that case, but anyway it means
the problem situation is unreachable, AFAICS.

It still seems worth fixing in HEAD, in case anyone ever tries to
remove that restriction; but I'm no longer feeling that we need
to back-patch it.

            regards, tom lane


В списке pgsql-bugs по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: BUG #15541: Use after release in PQprint
Следующее
От: Alvaro Herrera
Дата:
Сообщение: Re: BUG #15541: Use after release in PQprint