Re: BUG #8354: stripped positions can generate nonzero rank in ts_rank_cd

Bruce Momjian <bruce@momjian.us> writes:
> OK, combined patch attached.  Is this correct?  I keep hoping someone
> else will chime in with an opinion on this, but at this point I think
> what you have done is clear enough for me to commit for 9.4.

That whole function is seriously undercommented; I suppose it's not this
patch's charter to fix that, but we could at least write

!                           /* ignore words without positions */
!                 entry++;
!                 continue;

The proposed new documentation text seems pretty badly written.  How about

This function requires lexeme positional information to perform its
calculation.  Therefore it ignores any <quote>stripped</> lexemes in the
<type>tsvector</>.  If there are no unstripped lexemes in the input, the
result will be zero.

The parenthetical "See" text is ok.

            regards, tom lane