Re: BUG #16129: Segfault in tts_virtual_materialize in logical replication worker

=?utf-8?Q?Ond=C5=99ej?= Jirman <ienieghapheoghaiwida@xff.cz> writes:
> On Thu, Nov 21, 2019 at 11:08:54PM +0100, Tomas Vondra wrote:
>> 1) Print newtup.values and newtup.changed matches, so that we can check
>> it contains the tuple I shared before? There should be 8 elements in
>> each, with 'values' being values formatted as text, and 'changed' being
>> flags which values were updated.

> newtup.changed

> {true, true, false, true, true, true, true, true, false <repeats 1656 times>}

So column 3 is not getting replaced.  That seems to jibe with my
theory that slot_modify_cstrings is failing to handle that case
correctly.  Can you try applying the patch I posted and see if
it fixes the issue for you?

            regards, tom lane