Re: ON COMMIT temp table handling

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> +     if ((iscommit && bstate != TBLOCK_END) ||
> +         (!iscommit && bstate != TBLOCK_ABORT))
> +         return;

Why is temp table handling in need of looking into xact.c's private
state?  There is no other AtEOXact routine anywhere that does this.
ISTM either the above code is wrong, or every other AtEOXact routine
is wrong.

There are some other things I don't like about the patch, but I can
fix them myself.  This one I thought I'd better ask about.

            regards, tom lane