Re: SlabCheck leaks memory into TopMemoryContext

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: SlabCheck leaks memory into TopMemoryContext
Дата
Msg-id 15906.1579205741@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: SlabCheck leaks memory into TopMemoryContext  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Ответы Re: SlabCheck leaks memory into TopMemoryContext
Список pgsql-hackers
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> I think the one possible argument against this approach might be that it
> adds a field to the struct, so if you have an extension using a Slab
> context, it'll break if you don't rebuild it. But that only matters if
> we want to backpatch it (which I think is not the plan) and with memory
> context checking enabled (which does not apply to regular packages).

Huh?  That struct is private in slab.c, no?  Any outside code relying
on its contents deserves to break.

I do think we ought to back-patch this, given the horrible results
Andres showed.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: making the backend's json parser work in frontend code
Следующее
От: Tomas Vondra
Дата:
Сообщение: Re: SlabCheck leaks memory into TopMemoryContext