Re: psql not responding to SIGINT upon db reconnection

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: psql not responding to SIGINT upon db reconnection
Дата
Msg-id 1588058.1690220636@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: psql not responding to SIGINT upon db reconnection  ("Tristan Partin" <tristan@neon.tech>)
Ответы Re: psql not responding to SIGINT upon db reconnection  ("Tristan Partin" <tristan@neon.tech>)
Список pgsql-hackers
"Tristan Partin" <tristan@neon.tech> writes:
> v3 is attached which fixes up some code comments I added which I hadn't 
> attached to the commit already, sigh.

I don't care for this patch at all.  You're bypassing the pqsignal
abstraction layer that the rest of psql goes through, and the behavior
you're implementing isn't very nice.  People do not expect ^C to
kill psql - it should just stop the \c attempt and leave you as you
were.

Admittedly, getting PQconnectdbParams to return control on SIGINT
isn't too practical.  But you could probably replace that with a loop
around PQconnectPoll and test for CancelRequested in the loop.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jeff Davis
Дата:
Сообщение: Re: Use of additional index columns in rows filtering
Следующее
От: Tom Lane
Дата:
Сообщение: Removing the fixed-size buffer restriction in hba.c