Re: WIP: Aggregation push-down

Hello,

Thank you for this great feature !
I hope this will be reviewed/validated soon ;o)

Just a comment:
set enable_agg_pushdown to true;
isn't displayed in EXPLAIN (SETTINGS) syntax.


The following modification seems to fix that: 

src/backend/utils/misc/guc.c
 
         {"enable_agg_pushdown", PGC_USERSET, QUERY_TUNING_METHOD,
            gettext_noop("Enables aggregation push-down."),
            NULL,
            GUC_EXPLAIN   <<<<--- line Added --->>>>
        },
        &enable_agg_pushdown,
        false,
        NULL, NULL, NULL
    },


then
postgres=# set enable_agg_pushdown = true;
SET
postgres=# explain (settings) select 1;
                QUERY PLAN
------------------------------------------
 Result  (cost=0.00..0.01 rows=1 width=4)
 Settings: enable_agg_pushdown = 'on'
(2 rows)


Regards
PAscal



--
Sent from: https://www.postgresql-archive.org/PostgreSQL-hackers-f1928748.html