Re: Next commitfest app release is planned for March 18th
От | Tom Lane |
---|---|
Тема | Re: Next commitfest app release is planned for March 18th |
Дата | |
Msg-id | 1579213.1742579607@sss.pgh.pa.us обсуждение исходный текст |
Ответ на | Re: Next commitfest app release is planned for March 18th (Peter Eisentraut <peter@eisentraut.org>) |
Ответы |
Re: Next commitfest app release is planned for March 18th
|
Список | pgsql-hackers |
Peter Eisentraut <peter@eisentraut.org> writes: > I have a few pieces of feedback that could be addressed by additional > rules for how things are listed in the dashboard: > - If I'm the committer for a patch but not a reviewer, and the patch is > in "needs review" status, then the patch is formally speaking not > actionable by me and should not be under "Patches that are ready for > your review". Perhaps it should be under "Blocked on others" [namely > the reviewers], or in a different category. > - Conversely, if I'm the reviewer for a patch but not the committer, and > the patch is in "ready for committer" status, then it's also not > "Patches that are ready for your review". This might similarly be > "Blocked on others" [namely the committer]. Both of these things would work correctly only for patches that you have already claimed as committer. I'm not sure about other people, but I rarely claim a patch as committer until I'm actually on the verge of committing it. I might mark myself as reviewer sometime sooner than that, in which case your second proposal would be a net negative for me. I don't think we should encourage committers to claim patches early, because then they are a single point of failure (work-stoppage) in a way that a reviewer is not. Maybe we need a way for committers to mark patches as things they want to pay attention to, without thereby blocking other committers from taking up the patch? > - Also, my dashboard shows patches from past and future commitfests. I > don't know what I'm supposed to do with that. The purpose of having a > "current" commitfest is that you work on that one when it's current. This might make sense for the patch author, but I agree it's not appropriate for anyone else. regards, tom lane
В списке pgsql-hackers по дате отправления: