The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: tested, failed
Spec compliant: not tested
Documentation: tested, passed
Hello
Patch does not apply to master. Could you rebase?
Code looks good and very similar to "ALTER TABLE ... ALTER COLUMN ... DROP IDENTITY"
I noticed one bug:
create table testdrop (i int, b int, m int GENERATED ALWAYS AS ( i*2) stored);
insert into testdrop(i,b) values (3,4);
alter table testdrop alter COLUMN m drop expression ;
alter table testdrop drop column i;
Here is no "m" column anymore. Possible due some forgotten dependency?
regards, Sergei
The new status of this patch is: Waiting on Author