Re: heap_tuple_needs_freeze false positive

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> !     if (!(tuple->t_infomask & HEAP_XMAX_INVALID))
>       {
> !         if (!(tuple->t_infomask & HEAP_XMAX_IS_MULTI))

How about just one test,
if (!(tuple->t_infomask & (HEAP_XMAX_INVALID | HEAP_XMAX_IS_MULTI)))

But other than that quibble, yeah, it's a bug.  XMAX_INVALID means just
that: the xmax is not to be thought valid.
        regards, tom lane