Re: Comment in outfunc.c

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: Comment in outfunc.c
Дата
Msg-id
15666.1414200505@sss.pgh.pa.us
Ответ на
Comment in outfunc.c (Tatsuo Ishii)
Список
Дерево обсуждения
Comment in outfunc.c Tatsuo Ishii <ishii@postgresql.org>
Re: Comment in outfunc.c Tom Lane <tgl@sss.pgh.pa.us>
Tatsuo Ishii  writes:
> I saw this comment in _outQuery() in outfuncs.c:

> 	WRITE_ENUM_FIELD(commandType, CmdType);
> 	WRITE_ENUM_FIELD(querySource, QuerySource);
> 	/* we intentionally do not print the queryId field */
> 	WRITE_BOOL_FIELD(canSetTag);

> What is the resoning behind the comment?

We don't want the queryId copied when a view/rule is reloaded,
since there's no guarantee that the algorithm for computing it
is stable for the life of a PG major version.  Instead it's reset
to zero on reload, and any plugins that care can recompute it.

I suppose we could print it anyway and then ignore it on reload
but what's the point of that?
		regards, tom lane


В списке pgsql-hackers по дате отправления
От: Tatsuo Ishii
Дата:
Сообщение: Comment in outfunc.c
От: Drew Crawford
Дата:
Сообщение: security barrier INSERT
FAQ