Re: pgcrypto: Makefile check

Neil Conway <neilc@samurai.com> writes:
> This patch makes the pgcrypto Makefile check that a recognized random
> source has been defined. If no such source is defined, pgcrypto will
> compile successfully but will be unusable.

Oh?

> +$(error "Unrecognized random source: $(random)")

Doesn't look like a successful compile to me.  What's worse, this would
also cause maintenance operations (like "make clean") to fail.

(I see little point in this anyway given that the makefile defaults to
"random = silly" further up.)

            regards, tom lane