Re: [PATCH] readlink missing nul-termination in pg_rewind

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] readlink missing nul-termination in pg_rewind
Дата
Msg-id 15619.1432828370@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] readlink missing nul-termination in pg_rewind  (Abhijit Menon-Sen <ams@2ndQuadrant.com>)
Список pgsql-hackers
Abhijit Menon-Sen <ams@2ndQuadrant.com> writes:
> This is just something I noticed in passing. (I did a quick check of all
> the other uses of readlink in the source, and they do get this right.)

There's more random inconsistency than just this.  I think we should
standardize on the coding exhibited at, eg, basebackup.c:1023ff, which
positively ensures that it won't scribble on random memory if the
call returns an unexpected value.  Will fix.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Abhijit Menon-Sen
Дата:
Сообщение: [PATCH] readlink missing nul-termination in pg_rewind
Следующее
От: Robert Haas
Дата:
Сообщение: Re: About that re-release ...