Re: CPU costs of random_zipfian in pgbench

Поиск
Список
Период
Сортировка
От Georgios Kokolatos
Тема Re: CPU costs of random_zipfian in pgbench
Дата
Msg-id 155246731010.16480.15850913449923768119.pgcf@coridan.postgresql.org
обсуждение исходный текст
Ответ на Re: CPU costs of random_zipfian in pgbench  (Fabien COELHO <coelho@cri.ensmp.fr>)
Ответы Re: CPU costs of random_zipfian in pgbench
Список pgsql-hackers
The following review has been posted through the commitfest application:
make installcheck-world:  not tested
Implements feature:       not tested
Spec compliant:           not tested
Documentation:            not tested

For whatever it is worth, the patch looks good to me.

A minor nitpick would be to use a verb in the part:

`cost when the parameter in (0, 1)`

maybe:

`cost when the parameter's value is in (0, 1)` or similar.

Apart from that, I would suggest it that the patch could be moved to
Waiting for Author state.

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Kyotaro HORIGUCHI
Дата:
Сообщение: Re: Introduce timeout capability for ConditionVariableSleep
Следующее
От: Fabien COELHO
Дата:
Сообщение: Re: Offline enabling/disabling of data checksums