Robert Haas <robertmhaas@gmail.com> writes:
> I was looking at KNNGIST some more today and found myself trying to
> disentangle what match_clause_to_indexcol() is actually doing. It
> appears to me that the opfamily passed to that function is always the
> same as index->opfamily[indexcol], which seems like needless
> notational complexity. Maybe I'm missing something, but the attached
> patch seems to make things simpler and clearer. Thoughts?
+1. I think the existing coding dates from a time when we didn't have
IndexOptInfo at all, or at least didn't pass it around to all these
sub-functions, so there was no other path for getting at the info.
But if you're going to do that, get rid of DoneMatchingIndexKeys
altogether, along with the extra zero that plancat.c adds to the
opfamily array. We don't need to be using more than one way to
iterate over those arrays.
regards, tom lane