Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Дата
Msg-id 15052.1560455595@sss.pgh.pa.us
обсуждение исходный текст
Ответ на BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build  (PG Bug reporting form <noreply@postgresql.org>)
Ответы Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build  (YunQiang Su <wzssyqa@gmail.com>)
Список pgsql-bugs
PG Bug reporting form <noreply@postgresql.org> writes:
> MIPS r6 changes the encoding of LL/SC instruction,
> while the .set mips2 will force assembler to generate
> old encoding.
> ...
> In fact if we not willing to support MIPS I or any CPU without ll/sc
> at all, we can just remove .set mips2 here.

After further digging around, I'm liking the alternative of just
removing the ".set mips2" lines.  MIPS-I has been obsolete since 1989,
and the MIPS-II instruction set has a lot of other substantial advantages
over MIPS-I besides having LL/SC, so it's pretty hard to believe that
anyone is still using toolchains that default to assuming MIPS-I
instruction set.

Digging around in our archives, it looks like ".set mips2" was required
when it was added, but that was on the strength of testing with a
machine running Linux 2.4.27-r5k-cobalt.  We need to research when/if
Linux changed their default configuration.

            regards, tom lane



В списке pgsql-bugs по дате отправления:

Предыдущее
От: PG Bug reporting form
Дата:
Сообщение: BUG #15851: Concurrent Refresh of Materialized views not preserving the order of the underlying query
Следующее
От: Tom Lane
Дата:
Сообщение: Re: BUG #15851: Concurrent Refresh of Materialized views not preserving the order of the underlying query