Re: Updates of SE-PostgreSQL 8.4devel patches (r1403)

Martijn van Oosterhout <kleptog@svana.org> writes:
> On Tue, Jan 13, 2009 at 10:05:45AM -0300, Alvaro Herrera wrote:
>> pgace.h: you have a bunch of "static inline" functions in here.  As far
>> as I know this doesn't work in compilers other than GCC :-(

> Really? C99 requires it and MSVC does support it.

Wrong.  What C99 requires is a uselessly cumbersome form of "inline"
that is not compatible with the GCC feature.  We did actually implement
C99-compatible inlines in one or two places (in the sorting code IIRC),
but it's not something that I want to put up with on a large scale.

If you ran the current sepostgres patch through an actual C99 compiler,
it would fail.
        regards, tom lane