Re: parallel.c is not marked as test covered

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: parallel.c is not marked as test covered
Дата
Msg-id 14832.1466479013@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: parallel.c is not marked as test covered  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Ответы Re: parallel.c is not marked as test covered  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Список pgsql-hackers
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 6/19/16 5:55 PM, Tom Lane wrote:
>> Depending on what the percentage actually is, maybe we could treat
>> this like the "random" test, and allow a failure to be disregarded
>> overall?  But that doesn't seem very nice either, in view of our
>> increasing reliance on automated testing.  If "random" were failing
>> 90% of the time on some buildfarm critters, that would probably
>> indicate a real problem, but we'd likely not realize it for a long time.

> I think this test would only fail if it runs out of workers, and that 
> would only happen in an installcheck run against a server configured in 
> a nonstandard way or that is doing something else -- which doesn't 
> happen on the buildfarm.

Um, if you're speaking of select_parallel, that already runs in parallel
with two other regression tests, and there is no annotation in the
parallel_schedule file suggesting that adding more scripts to that group
would be bad.  But yes, perhaps putting this test into its own standalone
group would be enough of a fix.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: parallel.c is not marked as test covered
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Reviewing freeze map code