Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt
Дата
Msg-id 1440197.1755790079@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt  (Kirill Reshke <reshkekirill@gmail.com>)
Список pgsql-hackers
Kirill Reshke <reshkekirill@gmail.com> writes:
> On Thu, 21 Aug 2025 at 17:00, jian he <jian.universality@gmail.com> wrote:
>> RangeVar   *rel = (RangeVar *) linitial(stmt->relations);
>> if (!IsA(rel, RangeVar))

> These two lines are weird. Looks like  linitial(stmt->relations)
> should be assigned to variable with type Node* first?

We take that sort of shortcut in many places.  If there's not any need
for the code to deal with more than one node type, an extra variable
that's used just for the IsA test seems like a lot of notational
overhead.

            regards, tom lane



В списке pgsql-hackers по дате отправления: