Re: [PATCH] Make ENOSPC not fatal in semaphore creation

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Make ENOSPC not fatal in semaphore creation
Дата
Msg-id 1409550.1634480964@sss.pgh.pa.us
обсуждение исходный текст
Ответ на [PATCH] Make ENOSPC not fatal in semaphore creation  (mp39590@gmail.com)
Ответы Re: [PATCH] Make ENOSPC not fatal in semaphore creation  (Mikhail <mp39590@gmail.com>)
Re: [PATCH] Make ENOSPC not fatal in semaphore creation  (Mikhail <mp39590@gmail.com>)
Список pgsql-hackers
mp39590@gmail.com writes:
> We might be in situation when we have "just enough" semaphores in the
> system limit to start but previously crashed unexpectedly, in that case
> we won't be able to start again - semget() will return ENOSPC, despite
> the semaphores are ours, and we can recycle them, so check this
> situation and try to remove the semaphore, if we are unable - give up
> and abort.

AFAICS, this patch could be disastrous.  What if the semaphore in
question belongs to some other postmaster?

Also, you haven't explained why the existing (and much safer) recycling
logic in IpcSemaphoreCreate doesn't solve your problem.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: mp39590@gmail.com
Дата:
Сообщение: [PATCH] Make ENOSPC not fatal in semaphore creation
Следующее
От: Mikhail
Дата:
Сообщение: Re: [PATCH] Make ENOSPC not fatal in semaphore creation